[PATCH] D80874: [llvm-dwarfdump] Add a table header for -debug-line -verbose output

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 3 00:30:50 PDT 2020


jhenderson accepted this revision.
jhenderson added a comment.

LGTM, with one remaining request.



================
Comment at: llvm/test/tools/llvm-dwarfdump/X86/debug_line_invalid.test:41-42
 # FIRST:        debug_line[0x00000000]
-# VERBOSE:      DW_LNE_set_address (0x000000000badbeef)
+# VERBOSE:                  Address            Line   Column File   ISA Discriminator Flags
+# VERBOSE-NEXT:             ------------------ ------ ------ ------ --- ------------- -------------
+# VERBOSE-NEXT: DW_LNE_set_address (0x000000000badbeef)
----------------
Since the rest of this test doesn't line up with the header here, I'd just get rid of the extra spacing. The test looks odd to me with it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80874/new/

https://reviews.llvm.org/D80874





More information about the llvm-commits mailing list