[PATCH] D80923: GlobalISel: Start defining strict FP instructions

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 2 18:40:19 PDT 2020


arsenm marked an inline comment as done.
arsenm added inline comments.


================
Comment at: llvm/lib/CodeGen/GlobalISel/IRTranslator.cpp:1349
+  if (FPI.isTernaryOp())
+    VRegs.push_back(getOrCreateVReg(*FPI.getArgOperand(2)));
+
----------------
aemerson wrote:
> Why do we have to do this? Can't we somehow loop over the non-metadata operands?
I'm not sure. I expected ConstrainedFPIntrinsic to provide a nicer way to figure out the operands, but this is what's there and what SelectionDAGBuilder does.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80923/new/

https://reviews.llvm.org/D80923





More information about the llvm-commits mailing list