[PATCH] D80934: [AIX] Update data directives for AIX assembly
David Tenty via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Jun 2 13:43:22 PDT 2020
daltenty marked an inline comment as done.
daltenty added inline comments.
================
Comment at: llvm/lib/MC/MCAsmInfoXCOFF.cpp:23
AscizDirective = nullptr; // not supported
- Data64bitsDirective = "\t.llong\t";
COMMDirectiveAlignmentIsInBytes = false;
----------------
jasonliu wrote:
> I think the reason this was here is that we want to keep the same order as it is in the base class MCAsmInfo.
> Is that something we still want to do? (which means Data16bitsDirective and Data32bitsDirective needs to go here?)
I think it makes sense to move it here
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D80934/new/
https://reviews.llvm.org/D80934
More information about the llvm-commits
mailing list