[PATCH] D80943: [X86] Add a flag to guard the wide load

Craig Topper via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 2 13:43:19 PDT 2020


craig.topper accepted this revision.
craig.topper added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: llvm/lib/Target/X86/X86InstrInfo.td:1135
     return true;
-  if (ExtType == ISD::EXTLOAD)
+  if (ExtType == ISD::EXTLOAD && Subtarget->enableWideLoad())
     return LD->getAlignment() >= 4 && LD->isSimple();
----------------
Carrot wrote:
> craig.topper wrote:
> > Why not do this in loadi16 as well?
> LLVM IR doesn't have anyext, I failed to write a test case to trigger it. :(
yeah it is probably hard to trigger with so much promotion of i16 ops.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80943/new/

https://reviews.llvm.org/D80943





More information about the llvm-commits mailing list