[PATCH] D78831: [SVE] Upgrade VectorType tests to test new types

[Eli Friedman via Phabricator via llvm-commits]

efriedma added inline comments.


================
Comment at: llvm/unittests/IR/VectorTypesTest.cpp:231
+
+  std::array<VectorType *, 8> VTys = {VectorType::get(Int16Ty, {4, true}),
+                                      VectorType::get(Int16Ty, {4, false}),
----------------
fhahn wrote:
> This seems to cause the following warning on GreenDragon (
> http://green.lab.llvm.org/green/job/clang-stage1-cmake-RA-expensive/15985/console)
> 
> It would be great if you could take a look.
> 
> ```
> /Users/buildslave/jenkins/workspace/clang-stage1-cmake-RA-expensive/llvm-project/llvm/unittests/IR/VectorTypesTest.cpp:231:39: warning: suggest braces around initialization of subobject [-Wmissing-braces]
>   std::array<VectorType *, 8> VTys = {VectorType::get(Int16Ty, {4, true}),
>                                       ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>                                       {
> ```
Those warnings pop up all over the place (including other places in that build) if you use clang 5.0 or older to build clang.  clang prints a warning because std::array is actually a struct that contains a C array.  Newer versions suppress the warning, though.

Maybe we should teach CMake to pass -Wno-missing-braces to older versions of clang.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78831/new/

https://reviews.llvm.org/D78831