[PATCH] D80282: [AMDGPU] Make SGPR spills exec mask agnostic

[Matt Arsenault via Phabricator via llvm-commits]

arsenm accepted this revision.
arsenm added a comment.
This revision is now accepted and ready to land.

LGTM with some comment fixes



================
Comment at: llvm/lib/Target/AMDGPU/SIRegisterInfo.cpp:900
+  // This is not possible when the src value must be valid after spill
+  // or src is smaller than exec mask.  In which case use VGPR.
+  bool StoreExecInVGPR = !IsLoad && (SuperRegIsExec || !IsKill);
----------------
The "In which case use VGPR." reads weirdly to me


================
Comment at: llvm/lib/Target/AMDGPU/SIRegisterInfo.cpp:913
+  if (SuperRegIsExec) {
+    // do nothing; exec is already stored in VGPR or will be overwritten
+  } else if (StoreExecInVGPR) {
----------------
Capitalize


================
Comment at: llvm/lib/Target/AMDGPU/SIRegisterInfo.cpp:986
+  if (SuperRegIsExec && IsLoad) {
+    // do nothing; exec will be overwritten
+  } else if (StoreExecInVGPR) {
----------------
Capitalize


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80282/new/

https://reviews.llvm.org/D80282