[PATCH] D80599: [HWASan] Add sizeof(global) in report even if symbols missing.
Mitch Phillips via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Jun 2 12:37:58 PDT 2020
hctim added inline comments.
================
Comment at: compiler-rt/lib/hwasan/hwasan_report.cpp:352
+ uptr size = GetGlobalSizeFromDescriptor(mem);
+ if (size == 0)
+ Printf(
----------------
pcc wrote:
> Is `size == 0` realistic? I don't think you can declare a zero-size global in C.
Sorry - I don't understand the comment. `size == 0` here indicates that the descriptor lookup failed.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D80599/new/
https://reviews.llvm.org/D80599
More information about the llvm-commits
mailing list