[PATCH] D80787: [VPlan] Support extracting lanes for defs managed in VPTransformState.

Ayal Zaks via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 2 12:05:17 PDT 2020


Ayal added inline comments.


================
Comment at: llvm/lib/Transforms/Vectorize/VPlan.h:281
+    if (Data.PerPartOutput.count(Def)) {
+      auto *VecPart = Data.PerPartOutput[Def][Instance.Part];
+      // TODO: Cache created scalar values.
----------------
This should in general also support **scalar** Values set per part, i.e., invariants.
Going forward, better model extracts and inserts upfront in VPlan, rather than generating them on-demand during code-gen.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80787/new/

https://reviews.llvm.org/D80787





More information about the llvm-commits mailing list