[PATCH] D77172: Heat Coloring (3/3): Adding Heat Functionality to CallPrinter

David Li via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 2 12:05:12 PDT 2020


davidxl added inline comments.


================
Comment at: llvm/lib/Analysis/CallPrinter.cpp:29
 
+static cl::opt<bool> ShowHeatColors("callgraph-heat-colors", cl::init(false),
+                                    cl::Hidden,
----------------
Add a comment that this currently only shows static call counts.  Also a FIXME to show real counts when profile data is available


================
Comment at: llvm/lib/Analysis/CallPrinter.cpp:77
+    if (!CallMultiGraph) {
+      for (auto F = M->getFunctionList().begin(); F != M->getFunctionList().end(); ++F) {
+        for (auto pairF = F; pairF != M->getFunctionList().end(); ++pairF) {
----------------
This part can be folded into the previous loop that computes MaxFreq


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77172/new/

https://reviews.llvm.org/D77172





More information about the llvm-commits mailing list