[PATCH] D80945: [DebugInfo] Fix a fatal error originating from split-macro support

Tue Jun 2 11:32:31 PDT 2020

dblaikie added a comment.

In D80945#2068934 <https://reviews.llvm.org/D80945#2068934>, @probinson wrote:

> The correct fix is to emit the .debug_line.dwo section (which repeats the directory/file tables from the .debug_line section in the .o file) and have .debug_macro.dwo point to it.  "If a DW_MACRO_start_file entry is present, the header contains a reference to the .debug_line section of the compilation." (p.169)  Yes, it would be clearer to mention both normal and .dwo cases, and I will file a clarification issue about that, but I think the intent is clear.
>
> The description of the flag on p.166 is merely describing the relationship of the flag and the existence of the field.  It doesn't mean you can arbitrarily choose to omit the field.

+1 to all that - thanks Paul!

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80945/new/

https://reviews.llvm.org/D80945