[PATCH] D80959: [llvm-dwarfdump] Print =<offset> after --debug-* options in help output.

[Jonas Devlieghere via Phabricator via llvm-commits]

JDevlieghere added inline comments.


================
Comment at: llvm/tools/llvm-dwarfdump/llvm-dwarfdump.cpp:94
+  bool parse(Option &O, StringRef ArgName, StringRef Arg, BoolOption &Val) {
+    if (Arg != "")
+      return O.error("this is a flag and does not take a value.");
----------------
MaskRay wrote:
> I think this code path should be impossible.
> 
> `assert(!Arg.empty() && "this is a flag and does not take a value")`
It's not, see the test case for a counter example. 


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80959/new/

https://reviews.llvm.org/D80959