[PATCH] D80752: [AArch64]: BFloat MatMul Intrinsics&CodeGen

[Mikhail Maltsev via Phabricator via llvm-commits]

miyuki added inline comments.


================
Comment at: clang/lib/CodeGen/CGBuiltin.cpp:16160
   }
   case WebAssembly::BI__builtin_wasm_narrow_s_i8x16_i16x8:
   case WebAssembly::BI__builtin_wasm_narrow_u_i8x16_i16x8:
----------------
This chunk does not belong to the patch


================
Comment at: llvm/test/CodeGen/AArch64/aarch64-bf16-dotprod-intrinsics.ll:4
+; CHECK-LABEL: test_vbfdot_f32
+; CHECK: bfdot   v0.2s, v1.4h, v2.4h
+define <2 x float> @test_vbfdot_f32(<2 x float> %r, <4 x bfloat> %a, <4 x bfloat> %b) {
----------------
LukeGeeson wrote:
> LukeGeeson wrote:
> > miyuki wrote:
> > > Would it make sense to check the whole body of the compiled function?
> > Oops sorry, having all kinds of issues with my commit history here, give me a moment to address this
> I would say it's not worth testing the whole function here, the only code emitted for each is the instruction mentioned in the `CHECK` and a `ret` surrounded by lot's of compiler labels and directives that we don't need to test here
I meant, just the code from the first BB label to ret (inclusive), without directives. I suggest using `llvm/utils/update_llc_test_checks.py` to generate the checks.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80752/new/

https://reviews.llvm.org/D80752