[PATCH] D80249: WIP: CodeGen: Don't lazily construct MachineFunctionInfo

[Scott Linder via Phabricator via llvm-commits]

scott.linder added a comment.

I'm not comfortable accepting this as I'm not familiar with the code, but it LGTM. The pattern of constructing the `MachineFunctionInfo` lazily on the first call to `getInfo` seems very non-obvious; it isn't implied by the name and it isn't described in the doc comment. As you note it is also particularly dangerous if it depends on values which are mutable over the life of the `MachineFunction`.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80249/new/

https://reviews.llvm.org/D80249