[PATCH] D80937: Introduce a "gc-live" bundle for the gc arguments of a statepoint

[Anna Thomas via Phabricator via llvm-commits]

anna added a comment.

LGTM w/ comments inline.



================
Comment at: llvm/docs/Statepoints.rst:620
+corresponding statepoint.  If the statepoint has a :ref:`gc-live <ob_gc_live>`
+operand bundle, then the value is an index into the operand bundle's operands.
+If there is no "gc-live" bundle, then the index is into the statepoint's list
----------------
Nit: then *both arguments* are indices into the operand bundle's operand. 


================
Comment at: llvm/docs/Statepoints.rst:636
+argument if-and-only-if a base pointer is being relocated. This index must
+land within the 'gc parameter' section of the statepoint's argument list.
 
----------------
or within the operand list in `gc-live` bundle. 


================
Comment at: llvm/test/CodeGen/X86/statepoint-gc-live.ll:39
+
+define i8 addrspace(1)* @test_one(i8 addrspace(1)* %p) gc "statepoint-example" {
+; CHECK-LABEL: test_one:
----------------
Perhaps add a testcase for a relocated derived pointer?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80937/new/

https://reviews.llvm.org/D80937