[PATCH] D80803: [llvm-dwarfdump] Flush output before warning and errors are reported
Pavel Labath via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Jun 2 08:14:16 PDT 2020
labath added a comment.
Hm... that is unfortunate. I think that option (3) is the most correct approach -- I find the current ToolOutputFile behavior fairly problematic -- but you're right that it can have some unexpected knock-on effects, and so I'm not sure if this patch should be predicated on that.
(Incidentally, I was shocked to learn that the magicness of "-" is embedded directly into the raw_os_ostream constructor -- I would have expected this to be handled somewhere higher up (like the `ToolOutputFile` class, for instance).)
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D80803/new/
https://reviews.llvm.org/D80803
More information about the llvm-commits
mailing list