[PATCH] D80758: [PowerPC] Add -m[no-]power10-vector clang and llvm option

[Ahsan Saghir via Phabricator via llvm-commits]

saghir marked 2 inline comments as done.
saghir added inline comments.


================
Comment at: clang/lib/Basic/Targets/PPC.cpp:414
+    if (Name == "power9-vector")
+      Features["power10-vector"] = false;
     Features[Name] = false;
----------------
lei wrote:
> I think it would be good to change this into a switch-stmt as there are enough conditional changed based on `Name` and probably more to come.
Adding string switch here would complicate it more, so sticking with the current approach.


================
Comment at: llvm/lib/Target/PowerPC/PPC.td:219
                                          FeatureP9Altivec]>;
+def FeatureP10Altivec : SubtargetFeature<"power10-altivec", "HasP10Altivec",
+                                         "true",
----------------
lei wrote:
> what's the relationship between this and p10 vector support?
Removed P10Altivec since this is not really needed for P10.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80758/new/

https://reviews.llvm.org/D80758