[PATCH] D80924: [CostModel] Use MaybeAlign in getMemoryOpCost

[Guillaume Chatelet via Phabricator via llvm-commits]

gchatelet added a comment.

In D80924#2068291 <https://reviews.llvm.org/D80924#2068291>, @samparker wrote:

> Well, firstly I'd just like the interface to be consistent throughout the cost model and, since the IR doesn't force memory operations to have an alignment, I don't see why we'd try to enforce that here.


We're moving to a world where we want the alignment to be explicit at the IR level for loads and stores (see D77454 <https://reviews.llvm.org/D77454> and D79900 <https://reviews.llvm.org/D79900>).
So for consistency - which I agree is important - we should go in the opposite direction and straighten the type system with `Align` wherever possible.
I'm not super familiar with the code TBH, are there any //memory operations// handled by `getMemoryOpCost` that are neither load nor store?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80924/new/

https://reviews.llvm.org/D80924