[PATCH] D80136: [mlir] Erase or clear blocks through ConversionPatternRewriter when applicable

Tue Jun 2 04:24:57 PDT 2020

ftynse marked 2 inline comments as done.
ftynse added inline comments.
Herald added a project: MLIR.

================
Comment at: mlir/examples/toy/Ch5/mlir/LowerToAffineLoops.cpp:75
     auto loop = rewriter.create<AffineForOp>(loc, /*lb=*/0, dim, /*step=*/1);
-    loop.getBody()->clear();
+    for (Operation &nested : *loop.getBody())
+      rewriter.eraseOp(&nested);
----------------
rriddle wrote:
> This was because originally ensureTerminator wasn't tracked, so this could now be removed entirely. The create<AffineTerminatorOp> below would also need to be removed.
Thanks, done in b596ecdd574e3ec717f71950370d2f58ae44296f

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80136/new/

https://reviews.llvm.org/D80136