[PATCH] D80989: [DebugInfo] Make verbose line output appear at same point as non-verbose

Tue Jun 2 03:52:11 PDT 2020

jhenderson created this revision.
jhenderson added reviewers: JDevlieghere, ikudrin, aprantl, labath, dblaikie, probinson, MaskRay.
Herald added subscribers: cmtice, hiraditya.
Herald added a project: LLVM.
jhenderson edited the summary of this revision.
jhenderson added a parent revision: D80803: [llvm-dwarfdump] Flush output before warning and errors are reported.

Verbose and non-verbose parsing of .debug_line produced their output at different points in the program. The most obvious impact of this was                                                    that error messages were produced at different times, but it also potentially reduced what clients could do by customising the stream or                                                  warning/error handlers.

This change makes the two variants consistent by buffering the verbose output until the same point as non-verbose output is written. Testing of the error messages has been modified to check the messages always appear in the same location to illustrate the behaviour.

Depends on D80803 <https://reviews.llvm.org/D80803>.

Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D80989

Files:
  llvm/lib/DebugInfo/DWARF/DWARFContext.cpp
  llvm/test/tools/llvm-dwarfdump/X86/debug_line_invalid.test

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D80989.267836.patch
Type: text/x-patch
Size: 14194 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200602/588ce692/attachment.bin>