[PATCH] D80957: [LiveDebugValues] Cache LexicalScopes::getMachineBasicBlocks, NFCI

[Orlando Cazalet-Hyams via Phabricator via llvm-commits]

Orlando added a comment.

This makes sense to me.

If you're going to subclass and are paying for the callback indirection in LexicalScopes now anyway, would it not make sense to make `getMachineBasicBlocks` virtual instead of inheriting and using a callback? It seems like it could be simpler that way. I don't know if one way is better than the other, I'm just curious.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80957/new/

https://reviews.llvm.org/D80957