[PATCH] D80707: [legacyPM] Do not compute preserved analysis if there's no local change

Nicolai Hähnle via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 2 01:38:49 PDT 2020


nhaehnle added a comment.

In D80707#2065728 <https://reviews.llvm.org/D80707#2065728>, @serge-sans-paille wrote:

> > Perhaps if a pass returns false we should verify all analyses, rather than just the ones that the pass claims to preserve?
>
> That sounds like a good idea! Do you think that should be guarded by NDEBUG or by EXPENSIVE_CHECK?


Most analysis verifications only seems to run with EXPENSIVE_CHECKS enabled today, so I'd stay consistent with that.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80707/new/

https://reviews.llvm.org/D80707





More information about the llvm-commits mailing list