[PATCH] D80838: [llvm-ar] Add more tests for errors in opening archives

Tue Jun 2 01:38:47 PDT 2020

jhenderson added inline comments.

================
Comment at: llvm/test/tools/llvm-ar/print.test:81
+## No Permission
+# RUN: llvm-ar -rc %t/permission.b %t/1.txt
+# RUN: chmod 100 %t/permission.b
----------------
sameerarora101 wrote:
> jhenderson wrote:
> > Traditional llvm-ar calling does not use `-` for its arguments. See the existing test cases.
> calling llvm-ar with options `rc` was using a `-` as on line #9. Which one should I be following? 
When you move this to the new file, go without the `-`. Sorry, I didn't spot that there were earlier cases with it, but I'd consider those less than ideal.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80838/new/

https://reviews.llvm.org/D80838