[llvm] a05f1e5 - Add DIAError.h to list of headers excluded from the LLVM_DebugInfo_PDB module

[Daniel Grumberg via llvm-commits]

IIUC it belongs to the LLVM_DebugInfo_PDB_DIA module. What happened is that whoever added the file forgot to add to the list of excludes in the LLVM_DebugInfo_PDB module and it went unnoticed in normal builds and implicit module builds. I was doing some work on build system support for explicit module builds through clang-scan-deps which led to the issue coming up when building LLVM_DebugInfo_PDB.pcm explicitly.  Ideally there would a way to have globing support for exclude headers to avoid these kinds of issues (which I will do at some point in the near future), but I figured it would be good to fix the issue like this for the time being.

—Daniel

> On 1 Jun 2020, at 23:55, David Blaikie <dblaikie at gmail.com> wrote:
> 
> Why was this excluded?
> 
> On Mon, Jun 1, 2020 at 1:02 PM Daniel Grumberg via llvm-commits
> <llvm-commits at lists.llvm.org> wrote:
>> 
>> 
>> Author: Daniel Grumberg
>> Date: 2020-06-01T21:01:05+01:00
>> New Revision: a05f1e5ae4e0d0fc789a4caeff108fe4a50dc652
>> 
>> URL: https://github.com/llvm/llvm-project/commit/a05f1e5ae4e0d0fc789a4caeff108fe4a50dc652
>> DIFF: https://github.com/llvm/llvm-project/commit/a05f1e5ae4e0d0fc789a4caeff108fe4a50dc652.diff
>> 
>> LOG: Add DIAError.h to list of headers excluded from the LLVM_DebugInfo_PDB module
>> 
>> Differential Revision: https://reviews.llvm.org/D80808
>> 
>> Added:
>> 
>> 
>> Modified:
>>    llvm/include/llvm/module.modulemap
>> 
>> Removed:
>> 
>> 
>> 
>> ################################################################################
>> diff  --git a/llvm/include/llvm/module.modulemap b/llvm/include/llvm/module.modulemap
>> index 93c30d6d102e..a36b68491683 100644
>> --- a/llvm/include/llvm/module.modulemap
>> +++ b/llvm/include/llvm/module.modulemap
>> @@ -119,6 +119,7 @@ module LLVM_DebugInfo_PDB {
>>   exclude header "DebugInfo/PDB/DIA/DIAEnumSourceFiles.h"
>>   exclude header "DebugInfo/PDB/DIA/DIAEnumSymbols.h"
>>   exclude header "DebugInfo/PDB/DIA/DIAEnumTables.h"
>> +  exclude header "DebugInfo/PDB/DIA/DIAError.h"
>>   exclude header "DebugInfo/PDB/DIA/DIAFrameData.h"
>>   exclude header "DebugInfo/PDB/DIA/DIAInjectedSource.h"
>>   exclude header "DebugInfo/PDB/DIA/DIALineNumber.h"
>> 
>> 
>> 
>> _______________________________________________
>> llvm-commits mailing list
>> llvm-commits at lists.llvm.org
>> https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits