[PATCH] D80874: [llvm-dwarfdump] Add a table header for -debug-line -verbose output

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 2 00:31:22 PDT 2020


jhenderson added a comment.

Sorry, thought I posted this comment yesterday, but I guess not.



================
Comment at: llvm/lib/DebugInfo/DWARF/DWARFDebugLine.cpp:705-706
     Prologue.dump(*OS, DumpOptions);
+    *OS << '\n';
+    Row::dumpTableHeader(*OS, 12);
   }
----------------
Another thought: maybe we should only print the column headers if there is no `PrologueErr`. I'm also not convinced we need the extra new line before the header. I'd ideally like to see a test for that if it is to be included.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80874/new/

https://reviews.llvm.org/D80874





More information about the llvm-commits mailing list