[PATCH] D80959: [llvm-dwarfdump] Print =<offset> after --debug-* options in help output.
Jonas Devlieghere via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Jun 1 17:54:07 PDT 2020
JDevlieghere marked an inline comment as done.
JDevlieghere added inline comments.
================
Comment at: llvm/include/llvm/BinaryFormat/Dwarf.def:927
-// DWARF section types. (enum name, ELF name, ELF DWO name, cmdline name)
+// DWARF section types. (enum name, ELF name, ELF DWO name, cmdline name, option)
// Note that these IDs don't mean anything.
----------------
aprantl wrote:
> I'm not feeling very strongly about it, but I wonder if we should burden everyone's Dwarf.def with an implementation detail of llvm-dwarfdump.
Yeah, I'm not super happy about it either, but on the other hand we already have the cmdline name and it's easy to ignore.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D80959/new/
https://reviews.llvm.org/D80959
More information about the llvm-commits
mailing list