[PATCH] D80946: [AMDGPU/MemOpsCluster] Code clean-up around accessing of memory operand width

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 1 15:11:35 PDT 2020


arsenm added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/SIInstrInfo.h:836
 
+  unsigned getOpSize(const MachineInstr &MI, const MachineOperand &MO) const {
+    const TargetRegisterClass *DstRC = RI.getRegClassForReg(
----------------
Losing the units in the name is a regression. I would also pass in MRI explicitly rather than getting it from the parent function


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80946/new/

https://reviews.llvm.org/D80946





More information about the llvm-commits mailing list