[PATCH] D80311: [lld][test] Expand testing for dynamic-list and export-dynamic

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added a comment.

In D80311#2066890 <https://reviews.llvm.org/D80311#2066890>, @gbreynoo wrote:

> Thanks for the comments Maskray. I had some questions regarding the comments for expanding the test for use of -shared and the similarities with dynsym-pie.s, symbols.s and visibility.s. My intention with the test export-symbol-types.s was to confirm the  symbols types that are placed in the dynamic symbol table with use of --export-dynamic and --dynamic-list. I considered the other tests mentioned as covering related but different functionality using similar methods.  For example symbol.s being for correct symbol output as a whole, not specifically  exports etc.


I carefully checked. `export-symbol-types.s` makes sense, but the name may be confusing. `symbol types` refers specifically to `STT_*`, while in the test we are checking other properties (visibility/binding/etc).

> I can see there being a reason to expand the coverage of the existing test to cover -shared, this would require the rename and potentially splitting the existing test in two. It may also be worth creating one input assembly file that can be used for all these tests mentioned to ensure coverage. Could this wait for a future change however?
> 
> Also, with your comment were you suggesting removing some of the existing tests and folding them into the one added here? As they test different functionality I think it may be best to keep them separate.

`-shared` tests require to check preemptibility. This can usually tested by checking dynamic relocations. You can test them with `movl foo at gotpcrel(%rip), %rax`
They can be added in this patch. You can add `-shared` tests in a future change.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80311/new/

https://reviews.llvm.org/D80311