[PATCH] D80828: [Clang][A32/T32][Linux] -O2 implies -fomit-frame-pointer

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added inline comments.


================
Comment at: clang/test/Driver/frame-pointer-elim.c:125
+// For Android, keep the framepointers always.
+// RUN: %clang -### -target armv7a-linux-androideabi- -marm -O2 -S %s 2>&1 | \
+// RUN:   FileCheck --check-prefix=KEEP-ALL %s
----------------
`-O1` might be better. Users can infer that -O2 omits frame pointers as well since -O1 omits them.


================
Comment at: llvm/docs/ReleaseNotes.rst:97
+  not specifying a value and relying on the implicit compiler default may wish
+  to specify `-fno-omit-frame-pointer` to get the old behavior. This improves
+  compatibility with GCC.
----------------
Double backquotes.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80828/new/

https://reviews.llvm.org/D80828