[PATCH] D80663: [LangRef] Fix description of shape args for matrix.multiply.
Florian Hahn via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Jun 1 12:26:01 PDT 2020
fhahn added a comment.
In D80663#2063539 <https://reviews.llvm.org/D80663#2063539>, @braedy wrote:
> My concern using rows/columns in any of the argument names is that one of the dimensions changes from rows to columns, but you're right that perhaps outer isn't particularly descriptive enough and would require reading the overview instead of being able to understand it from just the signature.
Ah right. It doesn't change for the outer dimensions IIUC (so `OuterRows` & `OuterColumns` would be fine). it changes for the inner dimensions, which could be just `Inner` (or `InnerDim`)?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D80663/new/
https://reviews.llvm.org/D80663
More information about the llvm-commits
mailing list