[PATCH] D78369: [DebugInfo] Reduce SalvageDebugInfo() functions

Vedant Kumar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 1 12:25:44 PDT 2020


vsk accepted this revision.
vsk added a comment.
This revision is now accepted and ready to land.

This looks good to me. We should consolidate the salvageDebugInfo* APIs. I think the conversation about renaming the API is a bit moot post-D80264 (afaict the motivation for the rename was that /not/ calling the API could result in invalid debug info -- that should be fixed now).



================
Comment at: llvm/include/llvm/Transforms/Utils/Local.h:356
+/// debug users of \p I by writing the effect of \p I in a DIExpression. If it
+/// cannot be salvaged mark it undef.
+void salvageDebugInfo(Instruction &I);
----------------
Maybe 's/mark it/change its debug uses to/'?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78369/new/

https://reviews.llvm.org/D78369





More information about the llvm-commits mailing list