[PATCH] D79507: [flang] Change DIE("unreachable") cases to use llvm_unreachable

[David Blaikie via Phabricator via llvm-commits]

dblaikie added a comment.

In D79507#2066530 <https://reviews.llvm.org/D79507#2066530>, @hfinkel wrote:

> An another thought: we might have a separate cmake flag to transform DIE -> unreachable, or some form of DIE into unreachable, so that we can test the performance difference easily going forward.


Maybe? I wouldn't hold up that approach if you're really going for it - but I think it loses some of the benefits of/reason for the style guide: To make LLVM project code consistent & thus easier for LLVM developers to move between projects - being able to understand and write appropriate code in different areas.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79507/new/

https://reviews.llvm.org/D79507