[PATCH] D80929: [NFC][LiveDebugvalues] Document how LiveDebugValues operates

Jeremy Morse via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 1 10:12:28 PDT 2020


jmorse marked 4 inline comments as done.
jmorse added inline comments.


================
Comment at: llvm/lib/CodeGen/LiveDebugValues.cpp:54
+/// Formally, all DebugVariable locations that are live-out of a block blocks
+/// are initialized to \top, except in the entry block where they are \bot. The
+/// usual dataflow propagation then occurs: the transfer function for a block
----------------
vsk wrote:
> I don't follow this part: "except in the entry block where they [all DebugVariable locations that are live-out of a block] are \bot". Wouldn't that mean that a DebugVariable referenced in the entry block is unavailable in every other block?
Ah, that was an off-by-one, I should have written that the live-INS for the entry block are all \bot. I've fixed that and rotated the paragraph to have a different order, hopefully the same message comes across.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80929/new/

https://reviews.llvm.org/D80929





More information about the llvm-commits mailing list