[PATCH] D80929: [NFC][LiveDebugvalues] Document how LiveDebugValues operates

[Vedant Kumar via Phabricator via llvm-commits]

vsk added a comment.

This is really nice, thanks.



================
Comment at: llvm/lib/CodeGen/LiveDebugValues.cpp:35
+/// DBG_VALUEs too to track variable values bewteen locations. All this allows
+/// DbgValueHistoryCalculator to focus on only the locations within individual
+/// blocks, facilitating testing and improving modularity.
----------------
nit, DbgEntityHistoryCalculator?


================
Comment at: llvm/lib/CodeGen/LiveDebugValues.cpp:53
+/// 
+/// Formally, all DebugVariable locations that are live-out of a block blocks
+/// are initialized to \top, except in the entry block where they are \bot. The
----------------
nit, extra 'blocks'?


================
Comment at: llvm/lib/CodeGen/LiveDebugValues.cpp:54
+/// Formally, all DebugVariable locations that are live-out of a block blocks
+/// are initialized to \top, except in the entry block where they are \bot. The
+/// usual dataflow propagation then occurs: the transfer function for a block
----------------
I don't follow this part: "except in the entry block where they [all DebugVariable locations that are live-out of a block] are \bot". Wouldn't that mean that a DebugVariable referenced in the entry block is unavailable in every other block?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80929/new/

https://reviews.llvm.org/D80929