[PATCH] D80523: [DebugInfo] Report the format of debug info tables.

[Paul Robinson via Phabricator via llvm-commits]

probinson accepted this revision.
probinson added a comment.

LGTM with the suggested helper.



================
Comment at: llvm/include/llvm/BinaryFormat/Dwarf.h:484
 StringRef IndexString(unsigned Idx);
+StringRef FormatString(DwarfFormat Format);
 /// @}
----------------
And a helper taking `bool IsDWARF64)` here, so DWARFDebugFrame isn't using it's own idea of the format strings.
```
StringRef FormatString(bool IsDWARF64) {
  return FormatString(IsDWARF64 ? DWARF64 : DWARF32);
}
```


================
Comment at: llvm/lib/DebugInfo/DWARF/DWARFDebugFrame.cpp:318
+     << " CIE\n"
+     << "  Format:                " << (IsDWARF64 ? "DWARF64" : "DWARF32")
+     << "\n"
----------------
Use `FormatString(bool)` helper here.


================
Comment at: llvm/lib/DebugInfo/DWARF/DWARFDebugFrame.cpp:354
                InitialLocation + AddressRange);
+  OS << "  Format:       " << (IsDWARF64 ? "DWARF64" : "DWARF32") << "\n";
   if (LSDAAddress)
----------------
Use `FormatString(bool)` helper here.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80523/new/

https://reviews.llvm.org/D80523