[llvm] 745c6c8 - Process gep (phi ptr1, ptr2) in SROA
Stanislav Mekhanoshin via llvm-commits
llvm-commits at lists.llvm.org
Mon Jun 1 08:41:13 PDT 2020
Author: Stanislav Mekhanoshin
Date: 2020-06-01T08:41:05-07:00
New Revision: 745c6c8458babb31efc4e992a9c3e8598f03149f
URL: https://github.com/llvm/llvm-project/commit/745c6c8458babb31efc4e992a9c3e8598f03149f
DIFF: https://github.com/llvm/llvm-project/commit/745c6c8458babb31efc4e992a9c3e8598f03149f.diff
LOG: Process gep (phi ptr1, ptr2) in SROA
Differential Revision: https://reviews.llvm.org/D79218
Added:
llvm/test/Transforms/SROA/phi-gep.ll
Modified:
llvm/lib/Transforms/Scalar/SROA.cpp
Removed:
################################################################################
diff --git a/llvm/lib/Transforms/Scalar/SROA.cpp b/llvm/lib/Transforms/Scalar/SROA.cpp
index 1d486a3e74fd..7e92f7b06ecb 100644
--- a/llvm/lib/Transforms/Scalar/SROA.cpp
+++ b/llvm/lib/Transforms/Scalar/SROA.cpp
@@ -3475,15 +3475,60 @@ class AggLoadStoreRewriter : public InstVisitor<AggLoadStoreRewriter, bool> {
Sel->getName() + ".sroa.sel");
GEPI.replaceAllUsesWith(NSel);
GEPI.eraseFromParent();
+ Instruction *NSelI = cast<Instruction>(NSel);
+ Visited.insert(NSelI);
+ enqueueUsers(*NSelI);
LLVM_DEBUG(dbgs() << "\n to: " << *NTrue
<< "\n " << *NFalse
<< "\n " << *NSel << '\n');
- if (isa<Instruction>(NTrue))
- visit(cast<Instruction>(NTrue));
- if (isa<Instruction>(NFalse))
- visit(cast<Instruction>(NFalse));
+ return true;
+ }
+
+ // Fold gep (phi ptr1, ptr2) => phi gep(ptr1), gep(ptr2)
+ bool foldGEPPhi(GetElementPtrInst &GEPI) {
+ if (!GEPI.hasAllConstantIndices())
+ return false;
+
+ PHINode *PHI = cast<PHINode>(GEPI.getPointerOperand());
+ if (GEPI.getParent() != PHI->getParent() ||
+ llvm::any_of(PHI->incoming_values(), [](Value *In)
+ { Instruction *I = dyn_cast<Instruction>(In);
+ return !I || isa<GetElementPtrInst>(I) || isa<PHINode>(I) ||
+ !I->getParent()->isLegalToHoistInto();
+ }))
+ return false;
+
+ LLVM_DEBUG(dbgs() << " Rewriting gep(phi) -> phi(gep):"
+ << "\n original: " << *PHI
+ << "\n " << GEPI
+ << "\n to: ");
+
+ SmallVector<Value *, 4> Index(GEPI.idx_begin(), GEPI.idx_end());
+ bool IsInBounds = GEPI.isInBounds();
+ IRBuilderTy PHIBuilder(GEPI.getParent()->getFirstNonPHI());
+ PHINode *NewPN = PHIBuilder.CreatePHI(GEPI.getType(),
+ PHI->getNumIncomingValues(),
+ PHI->getName() + ".sroa.phi");
+ for (unsigned I = 0, E = PHI->getNumIncomingValues(); I != E; ++I) {
+ Instruction *In = cast<Instruction>(PHI->getIncomingValue(I));
+
+ IRBuilderTy B(In->getParent(), std::next(In->getIterator()));
+ Value *NewVal = IsInBounds
+ ? B.CreateInBoundsGEP(In, Index, In->getName() + ".sroa.gep")
+ : B.CreateGEP(In, Index, In->getName() + ".sroa.gep");
+ NewPN->addIncoming(NewVal, PHI->getIncomingBlock(I));
+ }
+
+ GEPI.replaceAllUsesWith(NewPN);
+ GEPI.eraseFromParent();
+ Visited.insert(NewPN);
+ enqueueUsers(*NewPN);
+
+ LLVM_DEBUG(for (Value *In : NewPN->incoming_values())
+ dbgs() << "\n " << *In;
+ dbgs() << "\n " << *NewPN << '\n');
return true;
}
@@ -3493,6 +3538,10 @@ class AggLoadStoreRewriter : public InstVisitor<AggLoadStoreRewriter, bool> {
foldGEPSelect(GEPI))
return true;
+ if (isa<PHINode>(GEPI.getPointerOperand()) &&
+ foldGEPPhi(GEPI))
+ return true;
+
enqueueUsers(GEPI);
return false;
}
diff --git a/llvm/test/Transforms/SROA/phi-gep.ll b/llvm/test/Transforms/SROA/phi-gep.ll
new file mode 100644
index 000000000000..c808dfc4a511
--- /dev/null
+++ b/llvm/test/Transforms/SROA/phi-gep.ll
@@ -0,0 +1,421 @@
+; NOTE: Assertions have been autogenerated by utils/update_test_checks.py
+; RUN: opt -S -sroa < %s | FileCheck %s
+
+%pair = type { i32, i32 }
+
+define i32 @test_sroa_phi_gep(i1 %cond) {
+; CHECK-LABEL: @test_sroa_phi_gep(
+; CHECK-NEXT: entry:
+; CHECK-NEXT: br i1 [[COND:%.*]], label [[IF_THEN:%.*]], label [[END:%.*]]
+; CHECK: if.then:
+; CHECK-NEXT: br label [[END]]
+; CHECK: end:
+; CHECK-NEXT: [[PHI_SROA_PHI_SROA_SPECULATED:%.*]] = phi i32 [ 1, [[ENTRY:%.*]] ], [ 2, [[IF_THEN]] ]
+; CHECK-NEXT: ret i32 [[PHI_SROA_PHI_SROA_SPECULATED]]
+;
+entry:
+ %a = alloca %pair, align 4
+ %b = alloca %pair, align 4
+ %gep_a = getelementptr inbounds %pair, %pair* %a, i32 0, i32 1
+ %gep_b = getelementptr inbounds %pair, %pair* %b, i32 0, i32 1
+ store i32 1, i32* %gep_a, align 4
+ store i32 2, i32* %gep_b, align 4
+ br i1 %cond, label %if.then, label %end
+
+if.then:
+ br label %end
+
+end:
+ %phi = phi %pair* [ %a, %entry], [ %b, %if.then ]
+ %gep = getelementptr inbounds %pair, %pair* %phi, i32 0, i32 1
+ %load = load i32, i32* %gep, align 4
+ ret i32 %load
+}
+
+define i32 @test_sroa_phi_gep_non_inbound(i1 %cond) {
+; CHECK-LABEL: @test_sroa_phi_gep_non_inbound(
+; CHECK-NEXT: entry:
+; CHECK-NEXT: br i1 [[COND:%.*]], label [[IF_THEN:%.*]], label [[END:%.*]]
+; CHECK: if.then:
+; CHECK-NEXT: br label [[END]]
+; CHECK: end:
+; CHECK-NEXT: [[PHI_SROA_PHI_SROA_SPECULATED:%.*]] = phi i32 [ 1, [[ENTRY:%.*]] ], [ 2, [[IF_THEN]] ]
+; CHECK-NEXT: ret i32 [[PHI_SROA_PHI_SROA_SPECULATED]]
+;
+entry:
+ %a = alloca %pair, align 4
+ %b = alloca %pair, align 4
+ %gep_a = getelementptr %pair, %pair* %a, i32 0, i32 1
+ %gep_b = getelementptr %pair, %pair* %b, i32 0, i32 1
+ store i32 1, i32* %gep_a, align 4
+ store i32 2, i32* %gep_b, align 4
+ br i1 %cond, label %if.then, label %end
+
+if.then:
+ br label %end
+
+end:
+ %phi = phi %pair* [ %a, %entry], [ %b, %if.then ]
+ %gep = getelementptr %pair, %pair* %phi, i32 0, i32 1
+ %load = load i32, i32* %gep, align 4
+ ret i32 %load
+}
+
+define i32 @test_sroa_phi_gep_undef(i1 %cond) {
+; CHECK-LABEL: @test_sroa_phi_gep_undef(
+; CHECK-NEXT: entry:
+; CHECK-NEXT: [[A:%.*]] = alloca [[PAIR:%.*]], align 4
+; CHECK-NEXT: br i1 [[COND:%.*]], label [[IF_THEN:%.*]], label [[END:%.*]]
+; CHECK: if.then:
+; CHECK-NEXT: br label [[END]]
+; CHECK: end:
+; CHECK-NEXT: [[PHI:%.*]] = phi %pair* [ [[A]], [[ENTRY:%.*]] ], [ undef, [[IF_THEN]] ]
+; CHECK-NEXT: [[GEP:%.*]] = getelementptr inbounds [[PAIR]], %pair* [[PHI]], i32 0, i32 1
+; CHECK-NEXT: [[LOAD:%.*]] = load i32, i32* [[GEP]], align 4
+; CHECK-NEXT: ret i32 [[LOAD]]
+;
+entry:
+ %a = alloca %pair, align 4
+ br i1 %cond, label %if.then, label %end
+
+if.then:
+ br label %end
+
+end:
+ %phi = phi %pair* [ %a, %entry], [ undef, %if.then ]
+ %gep = getelementptr inbounds %pair, %pair* %phi, i32 0, i32 1
+ %load = load i32, i32* %gep, align 4
+ ret i32 %load
+}
+
+ at g = global %pair zeroinitializer, align 4
+
+define i32 @test_sroa_phi_gep_global(i1 %cond) {
+; CHECK-LABEL: @test_sroa_phi_gep_global(
+; CHECK-NEXT: entry:
+; CHECK-NEXT: [[A:%.*]] = alloca [[PAIR:%.*]], align 4
+; CHECK-NEXT: [[GEP_A:%.*]] = getelementptr inbounds [[PAIR]], %pair* [[A]], i32 0, i32 1
+; CHECK-NEXT: store i32 1, i32* [[GEP_A]], align 4
+; CHECK-NEXT: br i1 [[COND:%.*]], label [[IF_THEN:%.*]], label [[END:%.*]]
+; CHECK: if.then:
+; CHECK-NEXT: br label [[END]]
+; CHECK: end:
+; CHECK-NEXT: [[PHI:%.*]] = phi %pair* [ [[A]], [[ENTRY:%.*]] ], [ @g, [[IF_THEN]] ]
+; CHECK-NEXT: [[GEP:%.*]] = getelementptr inbounds [[PAIR]], %pair* [[PHI]], i32 0, i32 1
+; CHECK-NEXT: [[LOAD:%.*]] = load i32, i32* [[GEP]], align 4
+; CHECK-NEXT: ret i32 [[LOAD]]
+;
+entry:
+ %a = alloca %pair, align 4
+ %gep_a = getelementptr inbounds %pair, %pair* %a, i32 0, i32 1
+ store i32 1, i32* %gep_a, align 4
+ br i1 %cond, label %if.then, label %end
+
+if.then:
+ br label %end
+
+end:
+ %phi = phi %pair* [ %a, %entry], [ @g, %if.then ]
+ %gep = getelementptr inbounds %pair, %pair* %phi, i32 0, i32 1
+ %load = load i32, i32* %gep, align 4
+ ret i32 %load
+}
+
+define i32 @test_sroa_phi_gep_arg_phi_inspt(i1 %cond) {
+; CHECK-LABEL: @test_sroa_phi_gep_arg_phi_inspt(
+; CHECK-NEXT: entry:
+; CHECK-NEXT: br i1 [[COND:%.*]], label [[FOR:%.*]], label [[END:%.*]]
+; CHECK: for:
+; CHECK-NEXT: [[PHI_INSPT:%.*]] = phi i32 [ 0, [[ENTRY:%.*]] ], [ [[I:%.*]], [[FOR]] ]
+; CHECK-NEXT: [[I]] = add i32 [[PHI_INSPT]], 1
+; CHECK-NEXT: [[LOOP_COND:%.*]] = icmp ult i32 [[I]], 10
+; CHECK-NEXT: br i1 [[LOOP_COND]], label [[FOR]], label [[END]]
+; CHECK: end:
+; CHECK-NEXT: [[PHI_SROA_PHI_SROA_SPECULATED:%.*]] = phi i32 [ 1, [[ENTRY]] ], [ 2, [[FOR]] ]
+; CHECK-NEXT: ret i32 [[PHI_SROA_PHI_SROA_SPECULATED]]
+;
+entry:
+ %a = alloca %pair, align 4
+ %b = alloca %pair, align 4
+ %gep_a = getelementptr inbounds %pair, %pair* %a, i32 0, i32 1
+ %gep_b = getelementptr inbounds %pair, %pair* %b, i32 0, i32 1
+ store i32 1, i32* %gep_a, align 4
+ store i32 2, i32* %gep_b, align 4
+ br i1 %cond, label %for, label %end
+
+for:
+ %phi_inspt = phi i32 [ 0, %entry ], [ %i, %for ]
+ %i = add i32 %phi_inspt, 1
+ %loop.cond = icmp ult i32 %i, 10
+ br i1 %loop.cond, label %for, label %end
+
+end:
+ %phi = phi %pair* [ %a, %entry], [ %b, %for ]
+ %gep = getelementptr inbounds %pair, %pair* %phi, i32 0, i32 1
+ %load = load i32, i32* %gep, align 4
+ ret i32 %load
+}
+
+define i32 @test_sroa_phi_gep_phi_inspt(i1 %cond) {
+; CHECK-LABEL: @test_sroa_phi_gep_phi_inspt(
+; CHECK-NEXT: entry:
+; CHECK-NEXT: [[A:%.*]] = alloca [[PAIR:%.*]], align 4
+; CHECK-NEXT: [[B:%.*]] = alloca [[PAIR]], align 4
+; CHECK-NEXT: [[GEP_A:%.*]] = getelementptr inbounds [[PAIR]], %pair* [[A]], i32 0, i32 1
+; CHECK-NEXT: [[GEP_B:%.*]] = getelementptr inbounds [[PAIR]], %pair* [[B]], i32 0, i32 1
+; CHECK-NEXT: store i32 1, i32* [[GEP_A]], align 4
+; CHECK-NEXT: store i32 2, i32* [[GEP_B]], align 4
+; CHECK-NEXT: br i1 [[COND:%.*]], label [[FOR:%.*]], label [[END:%.*]]
+; CHECK: for:
+; CHECK-NEXT: [[PHI_IN:%.*]] = phi %pair* [ null, [[ENTRY:%.*]] ], [ [[B]], [[FOR]] ]
+; CHECK-NEXT: [[PHI_INSPT:%.*]] = phi i32 [ 0, [[ENTRY]] ], [ [[I:%.*]], [[FOR]] ]
+; CHECK-NEXT: [[I]] = add i32 [[PHI_INSPT]], 1
+; CHECK-NEXT: [[LOOP_COND:%.*]] = icmp ult i32 [[I]], 10
+; CHECK-NEXT: br i1 [[LOOP_COND]], label [[FOR]], label [[END]]
+; CHECK: end:
+; CHECK-NEXT: [[PHI:%.*]] = phi %pair* [ [[A]], [[ENTRY]] ], [ [[PHI_IN]], [[FOR]] ]
+; CHECK-NEXT: [[GEP:%.*]] = getelementptr inbounds [[PAIR]], %pair* [[PHI]], i32 0, i32 1
+; CHECK-NEXT: [[LOAD:%.*]] = load i32, i32* [[GEP]], align 4
+; CHECK-NEXT: ret i32 [[LOAD]]
+;
+entry:
+ %a = alloca %pair, align 4
+ %b = alloca %pair, align 4
+ %gep_a = getelementptr inbounds %pair, %pair* %a, i32 0, i32 1
+ %gep_b = getelementptr inbounds %pair, %pair* %b, i32 0, i32 1
+ store i32 1, i32* %gep_a, align 4
+ store i32 2, i32* %gep_b, align 4
+ br i1 %cond, label %for, label %end
+
+for:
+ %phi_in = phi %pair * [ null, %entry ], [ %b, %for ]
+ %phi_inspt = phi i32 [ 0, %entry ], [ %i, %for ]
+ %i = add i32 %phi_inspt, 1
+ %loop.cond = icmp ult i32 %i, 10
+ br i1 %loop.cond, label %for, label %end
+
+end:
+ %phi = phi %pair* [ %a, %entry], [ %phi_in, %for ]
+ %gep = getelementptr inbounds %pair, %pair* %phi, i32 0, i32 1
+ %load = load i32, i32* %gep, align 4
+ ret i32 %load
+}
+
+define i32 @test_sroa_gep_phi_gep(i1 %cond) {
+; CHECK-LABEL: @test_sroa_gep_phi_gep(
+; CHECK-NEXT: entry:
+; CHECK-NEXT: [[A_SROA_0:%.*]] = alloca i32, align 4
+; CHECK-NEXT: br i1 [[COND:%.*]], label [[FOR:%.*]], label [[END:%.*]]
+; CHECK: for:
+; CHECK-NEXT: [[PHI_I:%.*]] = phi i32 [ 0, [[ENTRY:%.*]] ], [ [[I:%.*]], [[FOR]] ]
+; CHECK-NEXT: [[PHI:%.*]] = phi i32* [ [[A_SROA_0]], [[ENTRY]] ], [ [[GEP_FOR:%.*]], [[FOR]] ]
+; CHECK-NEXT: [[I]] = add i32 [[PHI_I]], 1
+; CHECK-NEXT: [[GEP_FOR]] = getelementptr inbounds i32, i32* [[PHI]], i32 0
+; CHECK-NEXT: [[LOOP_COND:%.*]] = icmp ult i32 [[I]], 10
+; CHECK-NEXT: br i1 [[LOOP_COND]], label [[FOR]], label [[END]]
+; CHECK: end:
+; CHECK-NEXT: [[PHI_END:%.*]] = phi i32* [ [[A_SROA_0]], [[ENTRY]] ], [ [[PHI]], [[FOR]] ]
+; CHECK-NEXT: [[LOAD:%.*]] = load i32, i32* [[PHI_END]], align 4
+; CHECK-NEXT: ret i32 [[LOAD]]
+;
+entry:
+ %a = alloca %pair, align 4
+ %gep_a = getelementptr inbounds %pair, %pair* %a, i32 0, i32 1
+ br i1 %cond, label %for, label %end
+
+for:
+ %phi_i = phi i32 [ 0, %entry ], [ %i, %for ]
+ %phi = phi i32* [ %gep_a, %entry], [ %gep_for, %for ]
+ %i = add i32 %phi_i, 1
+ %gep_for = getelementptr inbounds i32, i32* %phi, i32 0
+ %loop.cond = icmp ult i32 %i, 10
+ br i1 %loop.cond, label %for, label %end
+
+end:
+ %phi_end = phi i32* [ %gep_a, %entry], [ %phi, %for ]
+ %load = load i32, i32* %phi_end, align 4
+ ret i32 %load
+}
+
+define i32 @test_sroa_gep_cast_phi_gep(i1 %cond) {
+; CHECK-LABEL: @test_sroa_gep_cast_phi_gep(
+; CHECK-NEXT: entry:
+; CHECK-NEXT: [[A_SROA_0:%.*]] = alloca i32, align 4
+; CHECK-NEXT: [[A_SROA_0_0_GEP_A_1_SROA_CAST2:%.*]] = bitcast i32* [[A_SROA_0]] to float*
+; CHECK-NEXT: [[A_SROA_0_0_GEP_A_1_SROA_CAST:%.*]] = bitcast i32* [[A_SROA_0]] to float*
+; CHECK-NEXT: [[A_SROA_0_0_GEP_SROA_CAST:%.*]] = bitcast i32* [[A_SROA_0]] to float*
+; CHECK-NEXT: store i32 1065353216, i32* [[A_SROA_0]], align 4
+; CHECK-NEXT: br i1 [[COND:%.*]], label [[FOR:%.*]], label [[END:%.*]]
+; CHECK: for:
+; CHECK-NEXT: [[PHI_I:%.*]] = phi i32 [ 0, [[ENTRY:%.*]] ], [ [[I:%.*]], [[FOR]] ]
+; CHECK-NEXT: [[PHI:%.*]] = phi float* [ [[A_SROA_0_0_GEP_A_1_SROA_CAST2]], [[ENTRY]] ], [ [[GEP_FOR_2:%.*]], [[FOR]] ]
+; CHECK-NEXT: [[PHI_SROA_PHI:%.*]] = phi float* [ [[A_SROA_0_0_GEP_SROA_CAST]], [[ENTRY]] ], [ [[GEP_FOR_2_SROA_GEP:%.*]], [[FOR]] ]
+; CHECK-NEXT: [[I]] = add i32 [[PHI_I]], 1
+; CHECK-NEXT: [[GEP_FOR_1:%.*]] = bitcast float* [[PHI_SROA_PHI]] to i32*
+; CHECK-NEXT: [[GEP_FOR_2]] = bitcast i32* [[GEP_FOR_1]] to float*
+; CHECK-NEXT: [[GEP_FOR_2_SROA_GEP]] = getelementptr inbounds float, float* [[GEP_FOR_2]], i32 0
+; CHECK-NEXT: [[LOOP_COND:%.*]] = icmp ult i32 [[I]], 10
+; CHECK-NEXT: br i1 [[LOOP_COND]], label [[FOR]], label [[END]]
+; CHECK: end:
+; CHECK-NEXT: [[PHI_END:%.*]] = phi float* [ [[A_SROA_0_0_GEP_A_1_SROA_CAST]], [[ENTRY]] ], [ [[PHI]], [[FOR]] ]
+; CHECK-NEXT: [[PHI_END_1:%.*]] = bitcast float* [[PHI_END]] to i32*
+; CHECK-NEXT: [[LOAD:%.*]] = load i32, i32* [[PHI_END_1]], align 4
+; CHECK-NEXT: ret i32 [[LOAD]]
+;
+entry:
+ %a = alloca %pair, align 4
+ %gep_a = getelementptr inbounds %pair, %pair* %a, i32 0, i32 1
+ %gep_a.1 = bitcast i32* %gep_a to float*
+ store float 1.0, float* %gep_a.1, align 4
+ br i1 %cond, label %for, label %end
+
+for:
+ %phi_i = phi i32 [ 0, %entry ], [ %i, %for ]
+ %phi = phi float* [ %gep_a.1, %entry], [ %gep_for.2, %for ]
+ %i = add i32 %phi_i, 1
+ %gep_for = getelementptr inbounds float, float* %phi, i32 0
+ %gep_for.1 = bitcast float* %gep_for to i32*
+ %gep_for.2 = bitcast i32* %gep_for.1 to float*
+ %loop.cond = icmp ult i32 %i, 10
+ br i1 %loop.cond, label %for, label %end
+
+end:
+ %phi_end = phi float* [ %gep_a.1, %entry], [ %phi, %for ]
+ %phi_end.1 = bitcast float* %phi_end to i32*
+ %load = load i32, i32* %phi_end.1, align 4
+ ret i32 %load
+}
+
+define i32 @test_sroa_invoke_phi_gep(i1 %cond) personality i32 (...)* @__gxx_personality_v0 {
+; CHECK-LABEL: @test_sroa_invoke_phi_gep(
+; CHECK-NEXT: entry:
+; CHECK-NEXT: [[A:%.*]] = alloca [[PAIR:%.*]], align 4
+; CHECK-NEXT: br i1 [[COND:%.*]], label [[CALL:%.*]], label [[END:%.*]]
+; CHECK: call:
+; CHECK-NEXT: [[B:%.*]] = invoke %pair* @foo()
+; CHECK-NEXT: to label [[END]] unwind label [[INVOKE_CATCH:%.*]]
+; CHECK: end:
+; CHECK-NEXT: [[PHI:%.*]] = phi %pair* [ [[A]], [[ENTRY:%.*]] ], [ [[B]], [[CALL]] ]
+; CHECK-NEXT: [[GEP:%.*]] = getelementptr inbounds [[PAIR]], %pair* [[PHI]], i32 0, i32 1
+; CHECK-NEXT: [[LOAD:%.*]] = load i32, i32* [[GEP]], align 4
+; CHECK-NEXT: ret i32 [[LOAD]]
+; CHECK: invoke_catch:
+; CHECK-NEXT: [[RES:%.*]] = landingpad { i8*, i32 }
+; CHECK-NEXT: catch i8* null
+; CHECK-NEXT: ret i32 0
+;
+entry:
+ %a = alloca %pair, align 4
+ br i1 %cond, label %call, label %end
+
+call:
+ %b = invoke %pair* @foo()
+ to label %end unwind label %invoke_catch
+
+end:
+ %phi = phi %pair* [ %a, %entry], [ %b, %call ]
+ %gep = getelementptr inbounds %pair, %pair* %phi, i32 0, i32 1
+ %load = load i32, i32* %gep, align 4
+ ret i32 %load
+
+invoke_catch:
+ %res = landingpad { i8*, i32 }
+ catch i8* null
+ ret i32 0
+}
+
+define i32 @test_sroa_phi_gep_nonconst_idx(i1 %cond, i32 %idx) {
+; CHECK-LABEL: @test_sroa_phi_gep_nonconst_idx(
+; CHECK-NEXT: entry:
+; CHECK-NEXT: [[A:%.*]] = alloca [[PAIR:%.*]], align 4
+; CHECK-NEXT: [[B:%.*]] = alloca [[PAIR]], align 4
+; CHECK-NEXT: [[GEP_A:%.*]] = getelementptr inbounds [[PAIR]], %pair* [[A]], i32 0, i32 1
+; CHECK-NEXT: [[GEP_B:%.*]] = getelementptr inbounds [[PAIR]], %pair* [[B]], i32 0, i32 1
+; CHECK-NEXT: store i32 1, i32* [[GEP_A]], align 4
+; CHECK-NEXT: store i32 2, i32* [[GEP_B]], align 4
+; CHECK-NEXT: br i1 [[COND:%.*]], label [[IF_THEN:%.*]], label [[END:%.*]]
+; CHECK: if.then:
+; CHECK-NEXT: br label [[END]]
+; CHECK: end:
+; CHECK-NEXT: [[PHI:%.*]] = phi %pair* [ [[A]], [[ENTRY:%.*]] ], [ [[B]], [[IF_THEN]] ]
+; CHECK-NEXT: [[GEP:%.*]] = getelementptr inbounds [[PAIR]], %pair* [[PHI]], i32 [[IDX:%.*]], i32 1
+; CHECK-NEXT: [[LOAD:%.*]] = load i32, i32* [[GEP]], align 4
+; CHECK-NEXT: ret i32 [[LOAD]]
+;
+entry:
+ %a = alloca %pair, align 4
+ %b = alloca %pair, align 4
+ %gep_a = getelementptr inbounds %pair, %pair* %a, i32 0, i32 1
+ %gep_b = getelementptr inbounds %pair, %pair* %b, i32 0, i32 1
+ store i32 1, i32* %gep_a, align 4
+ store i32 2, i32* %gep_b, align 4
+ br i1 %cond, label %if.then, label %end
+
+if.then:
+ br label %end
+
+end:
+ %phi = phi %pair* [ %a, %entry], [ %b, %if.then ]
+ %gep = getelementptr inbounds %pair, %pair* %phi, i32 %idx, i32 1
+ %load = load i32, i32* %gep, align 4
+ ret i32 %load
+}
+
+define void @test_sroa_gep_phi_select_other_block() {
+; CHECK-LABEL: @test_sroa_gep_phi_select_other_block(
+; CHECK-NEXT: entry:
+; CHECK-NEXT: [[ALLOCA:%.*]] = alloca [[PAIR:%.*]], align 8
+; CHECK-NEXT: br label [[WHILE_BODY:%.*]]
+; CHECK: while.body:
+; CHECK-NEXT: [[PHI:%.*]] = phi %pair* [ [[ALLOCA]], [[ENTRY:%.*]] ], [ [[SELECT:%.*]], [[WHILE_BODY]] ]
+; CHECK-NEXT: [[SELECT]] = select i1 undef, %pair* [[PHI]], %pair* undef
+; CHECK-NEXT: br i1 undef, label [[EXIT:%.*]], label [[WHILE_BODY]]
+; CHECK: exit:
+; CHECK-NEXT: [[GEP:%.*]] = getelementptr inbounds [[PAIR]], %pair* [[PHI]], i64 1
+; CHECK-NEXT: unreachable
+;
+entry:
+ %alloca = alloca %pair, align 8
+ br label %while.body
+
+while.body:
+ %phi = phi %pair* [ %alloca, %entry ], [ %select, %while.body ]
+ %select = select i1 undef, %pair* %phi, %pair* undef
+ br i1 undef, label %exit, label %while.body
+
+exit:
+ %gep = getelementptr inbounds %pair, %pair* %phi, i64 1
+ unreachable
+}
+
+define void @test_sroa_gep_phi_select_same_block() {
+; CHECK-LABEL: @test_sroa_gep_phi_select_same_block(
+; CHECK-NEXT: entry:
+; CHECK-NEXT: [[ALLOCA:%.*]] = alloca [[PAIR:%.*]], align 8
+; CHECK-NEXT: br label [[WHILE_BODY:%.*]]
+; CHECK: while.body:
+; CHECK-NEXT: [[PHI:%.*]] = phi %pair* [ [[ALLOCA]], [[ENTRY:%.*]] ], [ [[SELECT:%.*]], [[WHILE_BODY]] ]
+; CHECK-NEXT: [[SELECT]] = select i1 undef, %pair* [[PHI]], %pair* undef
+; CHECK-NEXT: [[PHI_SROA_GEP:%.*]] = getelementptr inbounds [[PAIR]], %pair* [[PHI]], i64 1
+; CHECK-NEXT: [[SELECT_SROA_SEL:%.*]] = select i1 undef, %pair* [[PHI_SROA_GEP]], %pair* undef
+; CHECK-NEXT: br i1 undef, label [[EXIT:%.*]], label [[WHILE_BODY]]
+; CHECK: exit:
+; CHECK-NEXT: unreachable
+;
+entry:
+ %alloca = alloca %pair, align 8
+ br label %while.body
+
+while.body:
+ %phi = phi %pair* [ %alloca, %entry ], [ %select, %while.body ]
+ %select = select i1 undef, %pair* %phi, %pair* undef
+ %gep = getelementptr inbounds %pair, %pair* %select, i64 1
+ br i1 undef, label %exit, label %while.body
+
+exit:
+ unreachable
+}
+
+declare %pair* @foo()
+
+declare i32 @__gxx_personality_v0(...)
More information about the llvm-commits
mailing list