[PATCH] D80803: [llvm-dwarfdump] Flush output before warning and errors are reported

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 1 08:33:58 PDT 2020


jhenderson updated this revision to Diff 267625.
jhenderson retitled this revision from "[DebugInfo] Add flush to ensure debug line errors are in right place" to "[llvm-dwarfdump] Flush output before warning and errors are reported".
jhenderson edited the summary of this revision.
jhenderson added a reviewer: labath.
jhenderson added a subscriber: labath.
jhenderson added a comment.

Reimplemented flushing behaviour as part of the llvm-dwarfdump warning handler, as discussed. Also fixed an issue where the llvm-dwarfdump warning handler wasn't properly being copied around. I also have removed the two other existing flushes, as I believe we agree that it should be up to the handling methods to do the flushing as desired. Added @labath as a reviewer for this part, since he introduced them a few months ago.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80803/new/

https://reviews.llvm.org/D80803

Files:
  llvm/lib/DebugInfo/DWARF/DWARFContext.cpp
  llvm/test/tools/llvm-dwarfdump/X86/debug_line_invalid.test
  llvm/tools/llvm-dwarfdump/llvm-dwarfdump.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D80803.267625.patch
Type: text/x-patch
Size: 7215 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200601/cc3f04fc/attachment-0001.bin>


More information about the llvm-commits mailing list