[PATCH] D78861: [Attributor] Track AA dependency using dependency graph

Mon Jun 1 08:00:42 PDT 2020

jdoerfert added a comment.

In D78861#2066299 <https://reviews.llvm.org/D78861#2066299>, @kuter wrote:

> Hi, what is the state of this ?
>  As of D78729 <https://reviews.llvm.org/D78729> a AbstractAttribute keeps track of its own dependencies.
>
> It is possible to implement GraphTraits without using any extra memory by
>  directly implementing it on the Attributor and having the NodeRef as AbstractAttribute.
>
> I suggest that we make AADepGraph a empty (for now) wrapper that takes in a Attributor reference and implement GraphTraits on it.

Without thinking about this too much, I think this is reasonable. If it turns out we sometimes need a "richer" representation, we can allocate extra memory in the graph too, e.g., if the user asked for visualization of some special properties. For the start I, a thin overlay would be perfect.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78861/new/

https://reviews.llvm.org/D78861