[PATCH] D80838: [llvm-ar] Add more tests for errors in opening archives

Sameer Arora via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 1 06:55:53 PDT 2020


sameerarora101 marked 4 inline comments as done.
sameerarora101 added inline comments.


================
Comment at: llvm/test/tools/llvm-ar/print.test:81
+## No Permission
+# RUN: llvm-ar -rc %t/permission.b %t/1.txt
+# RUN: chmod 100 %t/permission.b
----------------
jhenderson wrote:
> Traditional llvm-ar calling does not use `-` for its arguments. See the existing test cases.
calling llvm-ar with options `rc` was using a `-` as on line #9. Which one should I be following? 


================
Comment at: llvm/test/tools/llvm-ar/print.test:82
+# RUN: llvm-ar -rc %t/permission.b %t/1.txt
+# RUN: chmod 100 %t/permission.b
+# RUN: not llvm-ar p %t/permission.b 2>&1 \
----------------
jhenderson wrote:
> Will this do what is expected for Windows users?
The test case `read-only-archive.test` is also using a `chmod` command and is supported for all systems (the file does not has a `UNSUPPORTED: system-windows` to mark the test as unsupported on windows). Thus, it should be fine?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80838/new/

https://reviews.llvm.org/D80838





More information about the llvm-commits mailing list