[PATCH] D80826: [CodeGen][SVE] Replace deprecated calls in getCopyFromPartsVector()

Henry Kao via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 1 06:23:40 PDT 2020


hkao13 marked an inline comment as done.
hkao13 added inline comments.


================
Comment at: llvm/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp:467
 
-  if (ValueVT.getVectorNumElements() != 1) {
+  if (ValueVT.getVectorElementCount().Min != 1) {
      // Certain ABIs require that vectors are passed as integers. For vectors
----------------
efriedma wrote:
> This has the same issues as the other check; it treats an nxv1i8 as having "one" element, and I'm not sure that's appropriate here.
I reverted this change as well. Thanks.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80826/new/

https://reviews.llvm.org/D80826





More information about the llvm-commits mailing list