[PATCH] D80803: [DebugInfo] Add flush to ensure debug line errors are in right place

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 1 04:14:34 PDT 2020


jhenderson added a comment.

I found having the error messages in different places somewhat confusing. Worse still, it seemed like occasionally they weren't consistent between being run under FileCheck and when I ran llvm-dwarfdump directly, although that might have only been tangentially related to when things were flushed. I'll take a look at moving the flushing to the error handler. It makes sense not to penalise the normal use-case, i.e. where there are no errors, by flushing unnecessarily.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80803/new/

https://reviews.llvm.org/D80803





More information about the llvm-commits mailing list