[PATCH] D80795: [llvm-dwarfdump][test] Use verbose output to check expected opcodes

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 1 03:41:53 PDT 2020


jhenderson added a comment.

In D80795#2065021 <https://reviews.llvm.org/D80795#2065021>, @MaskRay wrote:

> BTW, do you think the FileCheck option name `--implicit-check-not` is too long? It can easily cause line wraps if the option is repeated a few times. Does it deserve an alias? The same goes for --match-full-lines and --strict-whitespace


An alias for the options might well make sense. Also, perhaps we need an equivalent to `--check-prefixes` for `--implicit-check-not`, to allow something like `--implicit-check-nots=' DW_LNS, DW_LNE'`. We could of course combine multiple `--implicit-check-not` usages via regexes, but I think there's a risk of making easy mistakes that way.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80795/new/

https://reviews.llvm.org/D80795





More information about the llvm-commits mailing list