[PATCH] D80860: Exact integer emptiness checks for FlatAffineConstraints

[Jean-Michel Gorius via Phabricator via llvm-commits]

Kayjukh added inline comments.


================
Comment at: mlir/include/mlir/Analysis/Presburger/Matrix.h:9
+//
+// This a simple 2D matrix class that supports reading, writing, resizing,
+// swapping rows, and swapping columns.
----------------
`This a` -> `This is a`?


================
Comment at: mlir/include/mlir/Analysis/Presburger/Matrix.h:67
+};
+} // namespace mlir
+#endif // MLIR_ANALYSIS_PRESBURGER_MATRIX_H
----------------
nit: Add a blank line above this one.


================
Comment at: mlir/lib/Analysis/Presburger/Matrix.cpp:91
+
+} // namespace mlirs
----------------
`mlirs` -> `mlir`


================
Comment at: mlir/lib/Analysis/Presburger/Matrix.cpp:92
+} // namespace mlirs
\ No newline at end of file

----------------
nit: Add an empty line at the end of the file.


================
Comment at: mlir/unittests/Analysis/Presburger/SimplexTest.cpp:77
+}
+} // namespace mlir
----------------
nit: Add a blank line above this one.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80860/new/

https://reviews.llvm.org/D80860