[PATCH] D80889: AMDGPU: Fix not using scalar loads for global reads in shaders

Jay Foad via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 1 02:37:50 PDT 2020


foad added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUAnnotateUniformValues.cpp:133-134
   // We cannot go beyond because of FunctionPass restrictions
   // Thus we can ensure that memory not clobbered for memory
   // operations that live in kernel only.
+  bool NotClobbered = isEntryFunc && !isClobberedInFunction(&I);
----------------
Does the comment need updating?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80889/new/

https://reviews.llvm.org/D80889





More information about the llvm-commits mailing list