[PATCH] D80168: For --relativenames, handle dwarf absolute include directories similarly to compilation directories.

[James Henderson via Phabricator via llvm-commits]

jhenderson accepted this revision.
jhenderson added a comment.

LGTM, with nits.



================
Comment at: llvm/lib/DebugInfo/DWARF/DWARFDebugLine.cpp:1230
   if (getVersion() >= 5) {
-    if (Entry.DirIdx < IncludeDirectories.size())
+    // DirIdx 0 is the compilation directory, so for don't include it for
+    // relative names.
----------------
Nit: so for don't -> so don't


================
Comment at: llvm/test/tools/llvm-symbolizer/relativenames.s:5
+## See llvm/docs/CommandGuide/llvm-symbolizer.rst for commands
+## that would produce this test case
 
----------------
Nit: missing trailing full stop.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80168/new/

https://reviews.llvm.org/D80168