[PATCH] D80796: [DebugInfo] Add use of truncating data extractor to debug line parsing

Pavel Labath via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 1 01:01:52 PDT 2020


labath accepted this revision.
labath added a comment.

Looks good too. (and reminds me I should really get back to finishing my patch for parsing the prologue).



================
Comment at: llvm/test/tools/llvm-dwarfdump/X86/debug_line_invalid.test:251
+# VERBOSE-NEXT:  DW_LNS_copy
+# VERBOSE:       DW_LNE_set_address (0x0000000000000000)
+
----------------
Ideally, I think we should not print this opcode, as we weren't able to read all of it, but I think this is an improvement nonetheless.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80796/new/

https://reviews.llvm.org/D80796





More information about the llvm-commits mailing list