[PATCH] D80629: [yaml2obj] - Allocate the file space for SHT_NOBITS sections in some cases.

Mon Jun 1 01:01:51 PDT 2020

jhenderson accepted this revision.
jhenderson added a comment.
This revision is now accepted and ready to land.

LGTM, with nits and @MaskRay's comments addressed.

================
Comment at: llvm/test/tools/yaml2obj/ELF/program-header-nobits.yaml:101
+
+## Case D. We have a segment with SHT_NOBITS sections on its borders and a one
+##         non-nobits in the middle. Check we allocate the file space only for
----------------
a one -> one

================
Comment at: llvm/test/tools/yaml2obj/ELF/program-header-nobits.yaml:106
+# RUN: yaml2obj --docnum=2 %s -o %t4
+# RUN: llvm-readelf --sections -l %t4 | FileCheck %s --check-prefix=MIDDLE
+
----------------
Here and above, it's slightly offputting seeing a mixture of short and long options. I'd either go one or the other (i.e. `-S -l` or `--sections --segments`).

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80629/new/

https://reviews.llvm.org/D80629