[PATCH] D80373: [llvm-readobj] - Improve error reporting for hash tables.

[James Henderson via Phabricator via llvm-commits]

jhenderson accepted this revision.
jhenderson added a comment.
This revision is now accepted and ready to land.

LGTM, with nit.



================
Comment at: llvm/tools/llvm-readobj/ELFDumper.cpp:2648
+                            bool *IsHeaderValid = nullptr) {
+  auto BuildError = [&](uint64_t Off, const Twine &Msg = "") {
+    return createError("the hash table at offset 0x" + Twine::utohexstr(Off) +
----------------
Nit: I'd rename this `MakeError`, because I read `BuildError` and think there's something wrong with the build, rather than that this is for building an error.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80373/new/

https://reviews.llvm.org/D80373