[PATCH] D80787: [VPlan] Support extracting lanes for defs managed in VPTransformState.

Sjoerd Meijer via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 1 01:01:50 PDT 2020


SjoerdMeijer added inline comments.


================
Comment at: llvm/lib/Transforms/Vectorize/VPlan.h:283
+    }
+
     return Callback.getOrCreateScalarValue(VPValue2Value[Def], Instance);
----------------
Probably the comment about falling back to ILV now needs to be placed here?

And perhaps a brief comment added to the lines/comments above, what the reason could be for a Value not having a Def (at least I would be curious about that)?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80787/new/

https://reviews.llvm.org/D80787





More information about the llvm-commits mailing list