[PATCH] D80907: [PowerPC] refactor convertToImmediateForm - NFC

Kai Luo via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun May 31 23:25:40 PDT 2020


lkail added inline comments.


================
Comment at: llvm/lib/Target/PowerPC/PPCInstrInfo.cpp:3294
+  // Sign-extend to 64-bits.
+  int64_t SExtImm = ((uint64_t)Immediate & ~0x7FFFuLL) != 0
+                        ? (Immediate | 0xFFFFFFFFFFFF0000)
----------------
Can we use `SignExtend64<16>(Imm)` in `MathExtra.h` to simplify?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80907/new/

https://reviews.llvm.org/D80907





More information about the llvm-commits mailing list