[PATCH] D80497: Make mlir::Value's bool conversion operator explicit

[David Blaikie via Phabricator via llvm-commits]

dblaikie added a comment.

In D80497#2065377 <https://reviews.llvm.org/D80497#2065377>, @mehdi_amini wrote:

> Why? 
>  Given the tradeoff between breaking the build in master for many or having an extra email sent: I pick the latter without hesitation!


Different tradeoffs, it seems. Though those using the pre-commit checking could work on/make changes to Phabricator to enable pre-commit checking without sending email.

At least in the Web UI there's a way to change who a review is visible to? Perhaps you can make it just visible to yourself & maybe it'll still run the precommit checks but not send any email? (seems making it non-visible might thwart the pre-release testing herald rule, perhaps... )

Hey, looks like someone already added something to the LLVM herald rule, at least, not sure about the other subproject herald rules "Revision title does not contain [private]". So if you want an llvm commit to get precommit testing without sending llvm-dev mail, include "[private]" in the title. Other subprojects/mailing lists/rules could do similarly (I doubt there's any way we could make a general rule that overrides all the others... ) - though, I imagine,


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80497/new/

https://reviews.llvm.org/D80497